helmiazizm commented on code in PR #1392:
URL: https://github.com/apache/iceberg-python/pull/1392#discussion_r1868642737
##########
pyiceberg/io/pyarrow.py:
##########
@@ -350,7 +351,7 @@ def parse_location(location: str) -> Tuple[str, str, str]:
return uri.scheme, uri.netloc, f"{uri.netloc}{uri.path}"
def _initialize_fs(self, scheme: str, netloc: Optional[str] = None) ->
FileSystem:
- if scheme in {"s3", "s3a", "s3n"}:
+ if scheme in {"s3", "s3a", "s3n", "oss"}:
Review Comment:
> looks like theres https://github.com/fsspec/ossfs
The project hasn't been maintained for almost a year now, and when I tried
it on DuckDB it returns an unknown dependency error (?). I'd say it's probably
safer to use s3fs than ossfs (not that I've tried it, though). I'll try making
a new pull request for that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
