kevinjqliu commented on code in PR #1392: URL: https://github.com/apache/iceberg-python/pull/1392#discussion_r1868589197
########## pyiceberg/io/pyarrow.py: ########## @@ -350,7 +351,7 @@ def parse_location(location: str) -> Tuple[str, str, str]: return uri.scheme, uri.netloc, f"{uri.netloc}{uri.path}" def _initialize_fs(self, scheme: str, netloc: Optional[str] = None) -> FileSystem: - if scheme in {"s3", "s3a", "s3n"}: + if scheme in {"s3", "s3a", "s3n", "oss"}: Review Comment: lets also update the docs to mention `oss` https://py.iceberg.apache.org/configuration/#fileio -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org