pvary commented on code in PR #11662:
URL: https://github.com/apache/iceberg/pull/11662#discussion_r1861570865
##########
flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/sink/shuffle/SortKeySerializer.java:
##########
@@ -124,6 +124,14 @@ public void serialize(SortKey record, DataOutputView
target) throws IOException
for (int i = 0; i < size; ++i) {
int fieldId = transformedFields[i].fieldId();
Type.TypeID typeId = transformedFields[i].type().typeId();
+ Object value = record.get(i, Object.class);
Review Comment:
@stevenzwu: What do you think about a serializer version, something like the
SimpleVersionedSerializer uses. Maybe don't store the version for every key,
but inherit the version from the statistics object?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
