nastra commented on code in PR #11657:
URL: https://github.com/apache/iceberg/pull/11657#discussion_r1860184084
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/PositionDeletesRowReader.java:
##########
@@ -90,15 +95,23 @@ protected CloseableIterator<InternalRow>
open(PositionDeletesScanTask task) {
ExpressionUtil.extractByIdInclusive(
task.residual(), expectedSchema(), caseSensitive(),
Ints.toArray(nonConstantFieldIds));
- return newIterable(
+ if (ContentFileUtil.isDV(task.file())) {
+ DVIterable dvIterable = new DVIterable(inputFile, task.file(),
task.spec(), expectedSchema());
+ closeableGroup.addCloseable(dvIterable);
+ return dvIterable.iterator();
+ }
+
+ CloseableIterable<InternalRow> iterable =
+ newIterable(
inputFile,
task.file().format(),
task.start(),
task.length(),
residualWithoutConstants,
expectedSchema(),
- idToConstant)
- .iterator();
+ idToConstant);
+ closeableGroup.addCloseable(iterable);
Review Comment:
actually this isn't true and the closing is being handled in `BaseReader`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
