aokolnychyi commented on code in PR #11657: URL: https://github.com/apache/iceberg/pull/11657#discussion_r1859474395
########## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/DVIterable.java: ########## @@ -0,0 +1,147 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.spark.source; + +import java.io.IOException; +import java.nio.ByteBuffer; +import java.util.Iterator; +import java.util.List; +import org.apache.iceberg.DeleteFile; +import org.apache.iceberg.MetadataColumns; +import org.apache.iceberg.PartitionSpec; +import org.apache.iceberg.Schema; +import org.apache.iceberg.deletes.PositionDeleteIndex; +import org.apache.iceberg.io.CloseableGroup; +import org.apache.iceberg.io.CloseableIterable; +import org.apache.iceberg.io.CloseableIterator; +import org.apache.iceberg.io.InputFile; +import org.apache.iceberg.puffin.BlobMetadata; +import org.apache.iceberg.puffin.Puffin; +import org.apache.iceberg.puffin.PuffinReader; +import org.apache.iceberg.relocated.com.google.common.collect.Lists; +import org.apache.iceberg.util.Pair; +import org.apache.spark.sql.catalyst.InternalRow; +import org.apache.spark.sql.catalyst.expressions.GenericInternalRow; +import org.apache.spark.unsafe.types.UTF8String; + +class DVIterable extends CloseableGroup implements CloseableIterable<InternalRow> { + private final Puffin.ReadBuilder builder; + private final PartitionSpec spec; + private final DeleteFile deleteFile; + private final Schema projection; + + DVIterable(InputFile inputFile, DeleteFile deleteFile, PartitionSpec spec, Schema projection) { + this.deleteFile = deleteFile; + this.builder = Puffin.read(inputFile); + this.spec = spec; + this.projection = projection; + } + + @Override + public CloseableIterator<InternalRow> iterator() { + PuffinReader reader = builder.build(); + addCloseable(reader); + return new DVIterator(reader); + } + + private class DVIterator implements CloseableIterator<InternalRow> { + private final PuffinReader reader; + private final Iterator<Pair<BlobMetadata, ByteBuffer>> blobs; + private Pair<BlobMetadata, ByteBuffer> currentBlob; + private Iterator<Long> positions; + + DVIterator(PuffinReader reader) { + this.reader = reader; + try { + blobs = reader.readAll(reader.fileMetadata().blobs()).iterator(); + advanceBlob(); + } catch (IOException e) { + throw new RuntimeException(e); + } + } + + private void advanceBlob() { Review Comment: I am a bit confused as each DV is tracked by a separate `DeleteFile`. I'll need to see the main rewrite PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
