rahil-c commented on code in PR #11180:
URL: https://github.com/apache/iceberg/pull/11180#discussion_r1857154984


##########
core/src/test/java/org/apache/iceberg/TestBase.java:
##########
@@ -63,7 +63,7 @@ public class TestBase {
   public static final PartitionSpec SPEC =
       PartitionSpec.builderFor(SCHEMA).bucket("data", BUCKETS_NUMBER).build();
 
-  static final DataFile FILE_A =
+  public static final DataFile FILE_A =

Review Comment:
   @amogh-jahagirdar Just curious what is the concern/issue with the change? I 
think I can try adding this variable directly to tests but will need to do this 
in multiple places. Rather I think we can keep this change as the `TestBase` 
class seems to have other public variables, this seems to be clean to me.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to