pan3793 commented on code in PR #7732:
URL: https://github.com/apache/iceberg/pull/7732#discussion_r1853194071


##########
docs/docs/spark-configuration.md:
##########
@@ -167,16 +171,20 @@ spark.read
 
 ### Write options
 
-Spark write options are passed when configuring the DataFrameWriter, like this:
+Spark write options are passed when configuring the DataFrameWriterV2, like 
this:
 
 ```scala
 // write with Avro instead of Parquet
-df.write
+df.writeTo("catalog.db.table")
     .option("write-format", "avro")
     .option("snapshot-property.key", "value")
-    .insertInto("catalog.db.table")
+    .append()
 ```
 
+Iceberg 1.8.0 and later support setting write options by Spark session 
configuration `spark.datasource.iceberg.<key>=<value>`

Review Comment:
   I write it here because it's "Write options", actually, Spark has different 
concepts to allow the format/extensions to control the behavior, i.e. table 
properties, session configurations, options.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to