pan3793 commented on code in PR #7732:
URL: https://github.com/apache/iceberg/pull/7732#discussion_r1853187626
##########
docs/docs/spark-configuration.md:
##########
@@ -154,6 +154,10 @@ spark.read
.table("catalog.db.table")
```
+Iceberg 1.8.0 and later support setting read options by Spark session
configuration `spark.datasource.iceberg.<key>=<value>`
Review Comment:
I hesitate to write such a section because the situation looks more complex,
some configurations are allowed to be set by dedicated session configuration,
for example
```
public boolean localityEnabled() {
boolean defaultValue = Util.mayHaveBlockLocations(table.io(),
table.location());
return confParser
.booleanConf()
.option(SparkReadOptions.LOCALITY)
.sessionConf(SparkSQLProperties.LOCALITY)
.defaultValue(defaultValue)
.parse();
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
