RussellSpitzer commented on code in PR #11615:
URL: https://github.com/apache/iceberg/pull/11615#discussion_r1852423636
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkScan.java:
##########
@@ -183,6 +193,7 @@ public Statistics estimateStatistics() {
return estimateStatistics(SnapshotUtil.latestSnapshot(table, branch));
}
+ @SuppressWarnings("checkstyle:CyclomaticComplexity")
Review Comment:
Let's try to reduce the complexity rather than suppressing the warning
General this means
Removing nesting
Extracting sub-functions out
Avoiding early exits
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
