pvary commented on PR #10996: URL: https://github.com/apache/iceberg/pull/10996#issuecomment-2482012167
> @pvary @nastra @Fokko Given Hive 3.1 is already broken on JDK 11+ before this PR, how about skipping these failed tests not to block removing Hive 2? I think upgrading to Hive 4 is a bigger change and effort, and needs more time and discussion. Which tests are failing? I'm afraid that most of the Hive execution based tests use HiveShell, which is not able to start. This would mean that we effectively remove Hive execution testing. I would much prefer to move to Hive4, and keep testing. BTW I see Spark test failures. Old Spark used embedded Hive 1.2. That was the reason for some of the Hive version check in the HiveTableOpereation code. You might need to check that too. Thanks for working on this! Peter -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
