manuzhang commented on code in PR #10996:
URL: https://github.com/apache/iceberg/pull/10996#discussion_r1843854663
##########
mr/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergInputFormat.java:
##########
@@ -59,12 +57,12 @@ public class HiveIcebergInputFormat extends
MapredIcebergInputFormat<Record>
private static final Logger LOG =
LoggerFactory.getLogger(HiveIcebergInputFormat.class);
private static final String HIVE_VECTORIZED_RECORDREADER_CLASS =
"org.apache.iceberg.mr.hive.vector.HiveIcebergVectorizedRecordReader";
- private static final DynConstructors.Ctor<AbstractMapredIcebergRecordReader>
- HIVE_VECTORIZED_RECORDREADER_CTOR;
+ private static DynConstructors.Ctor<AbstractMapredIcebergRecordReader>
+ hiveVectorizedRecordreaderCtor;
Review Comment:
`HiveIcebergVectorizedRecordReader` is in `iceberg-hive3` module and can not
be loaded in `iceberg-mr` tests. Hence, we need to catch the exception and
reassign it to `null`. Same for `HiveVectorizedReader`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
