huaxingao commented on code in PR #10943:
URL: https://github.com/apache/iceberg/pull/10943#discussion_r1841589907
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/BaseRowReader.java:
##########
@@ -48,6 +50,17 @@ abstract class BaseRowReader<T extends ScanTask> extends
BaseReader<InternalRow,
super(table, taskGroup, tableSchema, expectedSchema, caseSensitive);
}
+ BaseRowReader(
+ Table table,
+ ScanTaskGroup<T> taskGroup,
+ Schema tableSchema,
+ Schema expectedSchema,
+ boolean caseSensitive,
+ Integer pushedLimit) {
+ this(table, taskGroup, tableSchema, expectedSchema, caseSensitive);
+ this.pushedLimit = pushedLimit;
Review Comment:
I think pushing it all the way to the reader could yield a bit more
performance gain.
Actually if filter exists, Spark side doesn't push down limit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
