RussellSpitzer commented on code in PR #10943:
URL: https://github.com/apache/iceberg/pull/10943#discussion_r1840791166
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkScanBuilder.java:
##########
@@ -405,14 +420,35 @@ public Scan build() {
private Scan buildBatchScan() {
Schema expectedSchema = schemaWithMetadataColumns();
+ org.apache.iceberg.Scan scan =
+ buildIcebergBatchScan(false /* not include Column Stats */,
expectedSchema);
+ if (pushedLimit != null && pushedLimit > 0 && hasDeletes(scan)) {
+ LOG.info("Skipping limit pushdown: detected row level deletes");
+ pushedLimit = null;
+ }
return new SparkBatchQueryScan(
spark,
table,
- buildIcebergBatchScan(false /* not include Column Stats */,
expectedSchema),
+ scan,
readConf,
expectedSchema,
filterExpressions,
- metricsReporter::scanReport);
+ metricsReporter::scanReport,
+ pushedLimit);
+ }
+
+ private boolean hasDeletes(org.apache.iceberg.Scan scan) {
Review Comment:
I agree that the scan is probably too expensive here and we probably should
only be doing it once for the various requirements we have. I also think we
should codify some of the keys and elements of the Summary, But for now I think
no one should be relying on the summary as a primary source of truth.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
