adutra commented on PR #10753: URL: https://github.com/apache/iceberg/pull/10753#issuecomment-2462696503
I rebased this PR and squashed the commits because the commit history was getting big. I only retained 3 commits: 1. [26f5e5f](https://github.com/apache/iceberg/pull/10753/commits/26f5e5fc4dcddcd7221a018c43f3f1267f5b5927) The original commit by @jackye1995 2. [9b82c1b](https://github.com/apache/iceberg/pull/10753/commits/9b82c1b9673c83d7d0a4f20d224c65f530679182) My original design where `AuthSession` is passed as a parameter to `RESTClient` 3. [c912c70](https://github.com/apache/iceberg/pull/10753/commits/c912c70810700ad4ccece82c79b797b39541aff3) The "new" design following @danielcweeks recommendations, where the`AuthSession` is wrapped inside `RESTClient`. @danielcweeks your suggestion resulted in a cleaner and less invasive design imho. Please review again 🙏 Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
