amogh-jahagirdar commented on code in PR #11273:
URL: https://github.com/apache/iceberg/pull/11273#discussion_r1828432675
##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestMergeOnReadDelete.java:
##########
@@ -99,6 +101,83 @@ public void testDeletePartitionGranularity() throws
NoSuchTableException {
checkDeleteFileGranularity(DeleteGranularity.PARTITION);
}
+ @TestTemplate
+ public void testPositionDeletesAreMaintainedDuringDelete() throws
NoSuchTableException {
+ String partitionStmt = "PARTITIONED BY (id)";
Review Comment:
There's not, in a previous version I had a helper method which would create
both partitioned/unpartitioned tables, and so I think this was just a remnant
from that. In the current one, we can just inline it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
