amogh-jahagirdar commented on code in PR #11273:
URL: https://github.com/apache/iceberg/pull/11273#discussion_r1828426913
##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestMergeOnReadDelete.java:
##########
@@ -99,6 +101,83 @@ public void testDeletePartitionGranularity() throws
NoSuchTableException {
checkDeleteFileGranularity(DeleteGranularity.PARTITION);
}
+ @TestTemplate
+ public void testPositionDeletesAreMaintainedDuringDelete() throws
NoSuchTableException {
+ String partitionStmt = "PARTITIONED BY (id)";
+ sql(
+ "CREATE TABLE %s (id int, data string) USING iceberg %s TBLPROPERTIES"
+ + "('%s'='%s', '%s'='%s', '%s'='%s')",
+ tableName,
+ partitionStmt,
+ TableProperties.FORMAT_VERSION,
+ 2,
+ TableProperties.DELETE_MODE,
+ "merge-on-read",
+ TableProperties.DELETE_GRANULARITY,
+ "file");
+ createBranchIfNeeded();
+
+ List<SimpleRecord> records =
+ Lists.newArrayList(
+ new SimpleRecord(1, "a"),
+ new SimpleRecord(1, "b"),
+ new SimpleRecord(1, "c"),
+ new SimpleRecord(2, "d"),
+ new SimpleRecord(2, "e"));
+ spark
+ .createDataset(records, Encoders.bean(SimpleRecord.class))
+ .coalesce(1)
+ .writeTo(commitTarget())
+ .append();
+
+ sql("DELETE FROM %s WHERE id = 1 and data='a'", commitTarget());
+ sql("DELETE FROM %s WHERE id = 2 and data='d'", commitTarget());
+ sql("DELETE FROM %s WHERE id = 1 and data='c'", commitTarget());
+
+ Table table = validationCatalog.loadTable(tableIdent);
+ Snapshot latest = SnapshotUtil.latestSnapshot(table, branch);
+ assertThat(latest.removedDeleteFiles(table.io())).hasSize(1);
+ assertEquals(
+ "Should have expected rows",
+ ImmutableList.of(row(1, "b"), row(2, "e")),
+ sql("SELECT * FROM %s ORDER BY id ASC", selectTarget()));
+ }
+
+ @TestTemplate
+ public void testUnpartitionedPositionDeletesAreMaintainedDuringDelete()
+ throws NoSuchTableException {
+ sql(
+ "CREATE TABLE %s (id int, data string) USING iceberg TBLPROPERTIES"
+ + "('format-version'='2', 'write.delete.mode'='merge-on-read',
'write.delete.granularity'='file')",
Review Comment:
Oh yeah good catch, strange I thought I updated all the tests, but seems
like I only got 1. Let me fix this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
