nastra commented on code in PR #11389:
URL: https://github.com/apache/iceberg/pull/11389#discussion_r1821941647
##########
aws/src/main/java/org/apache/iceberg/aws/AwsClientProperties.java:
##########
@@ -136,6 +156,12 @@ public <T extends AwsClientBuilder> void
applyClientCredentialConfigurations(T b
@SuppressWarnings("checkstyle:HiddenField")
public AwsCredentialsProvider credentialsProvider(
String accessKeyId, String secretAccessKey, String sessionToken) {
+ if (refreshCredentialsEnabled &&
!Strings.isNullOrEmpty(refreshCredentialsEndpoint)) {
Review Comment:
I'm not sure adding a warning adds a lot of value. It's valid to have the
server send you back an endpoint + refresh enabled flag that you then override
for cases like Kafka connect. I'd say let's go without a warning for now unless
this becomes a place of confusion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
