RussellSpitzer commented on code in PR #11389:
URL: https://github.com/apache/iceberg/pull/11389#discussion_r1821537570
##########
aws/src/main/java/org/apache/iceberg/aws/AwsClientProperties.java:
##########
@@ -136,6 +156,12 @@ public <T extends AwsClientBuilder> void
applyClientCredentialConfigurations(T b
@SuppressWarnings("checkstyle:HiddenField")
public AwsCredentialsProvider credentialsProvider(
String accessKeyId, String secretAccessKey, String sessionToken) {
+ if (refreshCredentialsEnabled &&
!Strings.isNullOrEmpty(refreshCredentialsEndpoint)) {
Review Comment:
nit: Should we log a warning if the endpoint is set but
refreshCredentialsEnabled is false? I don't think we should fail but this is
probably something a user would want to be aware of.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
