emkornfield commented on code in PR #11240:
URL: https://github.com/apache/iceberg/pull/11240#discussion_r1819906609


##########
format/spec.md:
##########
@@ -1494,6 +1536,20 @@ Writing v1 or v2 metadata:
     * For a single-arg transform, `source-id` should be written; if 
`source-ids` is also written it should be a single-element list of `source-id`
     * For multi-arg transforms, `source-ids` should be written; `source-id` 
should be set to the first element of `source-ids`
 
+Row-level delete changes:
+
+* Deletion vectors are added in v3, stored using the Puffin 
`deletion-vector-v1` blob type
+* Manifests are updated to track deletion vectors:
+    * `referenced_data_file` was added and can be used for both delection 
vectors (required) and v2 position delete files that contain deletes for only 
one data file (optional)

Review Comment:
   ```suggestion
       * `referenced_data_file` was added and can be used for both deletion 
vectors (required) and v2 position delete files that contain deletes for only 
one data file (optional)
   ```
   
   I know these are awesome but lets stick to standard naming :)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to