rdblue commented on code in PR #11240:
URL: https://github.com/apache/iceberg/pull/11240#discussion_r1819884060
##########
open-api/rest-catalog-open-api.py:
##########
@@ -854,6 +854,16 @@ class ContentFile(BaseModel):
class PositionDeleteFile(ContentFile):
content: Literal['position-deletes']
+ content_offset: Optional[int] = Field(
Review Comment:
I left out `referenced_data_file` because it is unnecessary. Position delete
files are sent back through server-side planning as a list. The file scan tasks
in the response include a list of indexes into that list to associate files
with the deletes that must be applied to them. Adding `referenced_data_file`
would duplicate that information and would be confusing, so I think it is
better to omit it.
Note that if we were to add fine-grained commits to the update API, we would
need to be able to pass it _to_ the service. We can add that later if/when
needed.
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -4202,6 +4203,14 @@ components:
content:
type: string
enum: [ "position-deletes" ]
+ content-offset:
Review Comment:
See my note above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
