Fokko commented on PR #11279: URL: https://github.com/apache/iceberg/pull/11279#issuecomment-2442559693
@ajantha-bhat First of all, thanks for working on this, and sorry for the late reply as I was on parental leave. Unfortunately, there are issues with this. I just ran the following to check what's being shipped: ```sh ./gradlew build -x test -x integrationTest ``` And noticed that we ship quite a bit in the fat jar: ```sh ls -lah open-api/build/libs/iceberg-open-api-* -rw-r--r-- 1 fokko.driesprong staff 6.0K Oct 28 21:12 open-api/build/libs/iceberg-open-api-1.7.0-SNAPSHOT-javadoc.jar -rw-r--r-- 1 fokko.driesprong staff 6.0K Oct 28 21:12 open-api/build/libs/iceberg-open-api-1.7.0-SNAPSHOT-sources.jar -rw-r--r-- 1 fokko.driesprong staff 9.5K Aug 27 20:18 open-api/build/libs/iceberg-open-api-1.7.0-SNAPSHOT-test-fixtures.jar -rw-r--r-- 1 fokko.driesprong staff 10K Oct 28 21:12 open-api/build/libs/iceberg-open-api-1.7.0-SNAPSHOT-tests.jar -rw-r--r-- 1 fokko.driesprong staff 109M Oct 28 21:12 open-api/build/libs/iceberg-open-api-test-fixtures-runtime-1.7.0-SNAPSHOT.jar ``` When looking into the runtime: ```sh mkdir /tmp/vo mv open-api/build/libs/iceberg-open-api-test-fixtures-runtime-1.7.0-SNAPSHOT.jar /tmp/vo/iceberg-open-api-test-fixtures-runtime-1.7.0-SNAPSHOT.jar cd /tmp/vo unzip iceberg-open-api-test-fixtures-runtime-1.7.0-SNAPSHOT.jar ``` And looking at the content, it looks like we ship a LOT, much more than mentioned in the LICENSE. Including at least one licenses that we [cannot ship](https://www.apache.org/legal/resolved.html#category-x) as it is part of the category X: ```sh ls -lah | grep -i lgpl -rw-r--r-- 1 fokko.driesprong wheel 7.5K Feb 1 1980 LGPL-3.0.txt ``` Also for the release we probably want to track down where this comes from. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
