bryanck commented on code in PR #11279:
URL: https://github.com/apache/iceberg/pull/11279#discussion_r1805111909


##########
build.gradle:
##########
@@ -1006,6 +1009,37 @@ project(':iceberg-open-api') {
     recommend.set(true)
   }
   check.dependsOn('validateRESTCatalogSpec')
+
+  // Create a custom configuration that extends testFixturesImplementation and 
is resolvable
+  configurations {
+    testFixturesShadowImplementation {
+      canBeResolved = true
+      canBeConsumed = false
+      extendsFrom testFixturesImplementation
+    }
+  }
+
+  shadowJar {
+    archiveBaseName.set("iceberg-open-api-test-fixtures-runtime")
+    archiveClassifier.set(null)
+    configurations = [project.configurations.testFixturesShadowImplementation]
+    from sourceSets.testFixtures.output
+    zip64 true
+
+    // include the LICENSE and NOTICE files for the runtime Jar
+    from(projectDir) {
+      include 'LICENSE'

Review Comment:
   It can generate both, but I added some logic to my custom renderer to dedupe 
the notices.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to