ajantha-bhat commented on code in PR #11216:
URL: https://github.com/apache/iceberg/pull/11216#discussion_r1818418685
##########
core/src/main/java/org/apache/iceberg/PartitionStats.java:
##########
@@ -249,4 +250,45 @@ public <T> void set(int pos, T value) {
throw new UnsupportedOperationException("Unknown position: " + pos);
}
}
+
+ @Override
+ @SuppressWarnings("checkstyle:CyclomaticComplexity")
+ public boolean equals(Object other) {
+ if (this == other) {
+ return true;
+ } else if (!(other instanceof PartitionStats)) {
+ return false;
+ }
+
+ PartitionStats that = (PartitionStats) other;
+ return Objects.equals(partition, that.partition)
Review Comment:
We are storing `Record` as `Partition` from `coercedPartitionRecord()`.
Since `GenericRecord` has `equals` implemented, calling `Objects.equals` is
working here.
Hence, I didn't add comparator logic.
But agree that need to understand the implementation logic, just by looking
at this class, it looks like we need comparator logic. I can update it if it is
necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
