bryanck commented on code in PR #11346:
URL: https://github.com/apache/iceberg/pull/11346#discussion_r1811331398
##########
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/RecordConverter.java:
##########
@@ -126,10 +127,14 @@ private Object convertValue(
case STRING:
return convertString(value);
case UUID:
+ if ("parquet".equals(config.writeProps().get("write.format.default")))
{
+ return UUIDUtil.convert(convertUUID(value));
+ }
return convertUUID(value);
case BINARY:
- case FIXED:
return convertBase64Binary(value);
+ case FIXED:
+ return convertBase64Binary(value).array();
Review Comment:
+1 for `ByteBuffers.toByteArray()`. The buffer shouldn't be reused, a record
is converted to an Iceberg row, written, then dereferenced. I don't believe any
of the writers cache rows as-is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
