RussellSpitzer commented on code in PR #11346:
URL: https://github.com/apache/iceberg/pull/11346#discussion_r1811295504
##########
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/RecordConverter.java:
##########
@@ -126,10 +127,14 @@ private Object convertValue(
case STRING:
return convertString(value);
case UUID:
+ if ("parquet".equals(config.writeProps().get("write.format.default")))
{
+ return UUIDUtil.convert(convertUUID(value));
+ }
return convertUUID(value);
case BINARY:
- case FIXED:
return convertBase64Binary(value);
+ case FIXED:
+ return convertBase64Binary(value).array();
Review Comment:
ByteBuffers.toByteArray(...)
Also just making sure, we won't be re-using this buffer anywhere?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
