simonykq commented on issue #10710:
URL: https://github.com/apache/iceberg/issues/10710#issuecomment-2427309738

   @pvary I looked a bit into the implementation around `WriteResult.class`.  
For `DataFiles` and `DeleteFiles`,  it seems to use the 
`org.apache.iceberg.BaseFile` as the implementation. Could you make the 
following changes so that it will get serialized using Pojo seralization as 
documented in Flink 
(https://nightlies.apache.org/flink/flink-docs-master/docs/dev/datastream/fault-tolerance/serialization/types_serialization/#pojos)
 ?
   
   For the `CharSequence[]`, I guess you could just serialize it as array of 
`String`?
   
   1. Make that class and all subclasses (`GenericDataFile` and 
`GenericDeleteFile`) public
   2. Create a public constructor with no args
   3. Make sure all non-static and non-transient fields in those classes are 
non-final and create a getter setter for them following Java bean convension
   
   I believe if you do that, the `WriteResult.class` would be treated as Pojo 
and therefore kicked in flink's `PojoTypeInfo`?
   
   You might
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to