amogh-jahagirdar commented on code in PR #11180:
URL: https://github.com/apache/iceberg/pull/11180#discussion_r1807542082
##########
core/src/test/java/org/apache/iceberg/TestBase.java:
##########
@@ -63,7 +63,7 @@ public class TestBase {
public static final PartitionSpec SPEC =
PartitionSpec.builderFor(SCHEMA).bucket("data", BUCKETS_NUMBER).build();
- static final DataFile FILE_A =
+ public static final DataFile FILE_A =
Review Comment:
Why did these need to change?
##########
core/src/test/java/org/apache/iceberg/TestBase.java:
##########
@@ -63,7 +63,7 @@ public class TestBase {
public static final PartitionSpec SPEC =
PartitionSpec.builderFor(SCHEMA).bucket("data", BUCKETS_NUMBER).build();
- static final DataFile FILE_A =
+ public static final DataFile FILE_A =
Review Comment:
I see, this is used in the tests below. Could we just have the tests which
use this to extend `TestBase?
##########
core/src/main/java/org/apache/iceberg/rest/responses/PlanTableScanResponse.java:
##########
@@ -0,0 +1,122 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.iceberg.rest.responses;
+
+import java.util.List;
+import org.apache.iceberg.DeleteFile;
+import org.apache.iceberg.FileScanTask;
+import org.apache.iceberg.relocated.com.google.common.base.MoreObjects;
+import org.apache.iceberg.rest.PlanStatus;
+import org.apache.iceberg.rest.RESTResponse;
+
+public class PlanTableScanResponse implements RESTResponse {
+ private PlanStatus planStatus;
+ private String planId;
+ private List<String> planTasks;
+ private List<FileScanTask> fileScanTasks;
+ private List<DeleteFile> deleteFiles;
+
+ private PlanTableScanResponse(
+ PlanStatus planStatus,
+ String planId,
+ List<String> planTasks,
+ List<FileScanTask> fileScanTasks,
+ List<DeleteFile> deleteFiles) {
+ this.planStatus = planStatus;
+ this.planId = planId;
+ this.planTasks = planTasks;
+ this.fileScanTasks = fileScanTasks;
+ this.deleteFiles = deleteFiles;
+ }
+
+ public PlanStatus planStatus() {
+ return planStatus;
+ }
+
+ public String planId() {
+ return planId;
+ }
+
+ public List<String> planTasks() {
+ return planTasks;
+ }
+
+ public List<FileScanTask> fileScanTasks() {
+ return fileScanTasks;
+ }
+
+ public List<DeleteFile> deleteFiles() {
+ return deleteFiles;
+ }
+
+ @Override
+ public String toString() {
+ return MoreObjects.toStringHelper(this)
+ .add("planStatus", planStatus)
+ .add("planId", planId)
+ .add("planTasks", planTasks)
+ .add("fileScanTasks", fileScanTasks)
+ .add("deleteFiles", deleteFiles)
Review Comment:
Let's double check that some of these `toString` make sense, I think we
shouldn't really be outputting in file scan tasks/delete files, it'll just be
references that a user won't really make sense of in logs. I think we should
just remove everything except status and ID here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
