amogh-jahagirdar commented on code in PR #11180:
URL: https://github.com/apache/iceberg/pull/11180#discussion_r1803556362
##########
core/src/main/java/org/apache/iceberg/BaseFile.java:
##########
@@ -434,6 +434,11 @@ public StructLike partition() {
return partitionData;
}
+ public void setPartitionData(PartitionData partitionData) {
Review Comment:
Agreed. @rahil-c could we just reuse the existing constructor and copy over
everything correctly with the new partition data during the binding? We should
avoid exposing unnecessary public APIs when possibke
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
