dmeaux commented on code in PR #10981: URL: https://github.com/apache/iceberg/pull/10981#discussion_r1804508892
########## format/spec.md: ########## @@ -483,6 +485,8 @@ Notes: 2. For `float` and `double`, the value `-0.0` must precede `+0.0`, as in the IEEE 754 `totalOrder` predicate. NaNs are not permitted as lower or upper bounds. 3. If sort order ID is missing or unknown, then the order is assumed to be unsorted. Only data files and equality delete files should be written with a non-null order id. [Position deletes](#position-delete-files) are required to be sorted by file and position, not a table order, and should set sort order id to null. Readers must ignore sort order id for position delete files. 4. The following field ids are reserved on `data_file`: 141. +5. For `geometry`, this is a point. X = min value of all component points of all geometries in file when edges = PLANAR, westernmost bound of all geometries in file if edges = SPHERICAL. Y = max value of all component points of all geometries in file when edges = PLANAR, northernmost bound of all geometries if edges = SPHERICAL. Z is min value for all component points of all geometries in the file. M is min value of all component points of all geometries in the file. See Appendix D for encoding. Review Comment: I think "edges = PLANAR" should be "edges = LINEAR" and "edges = SPHERICAL" should be "edges = GEODESIC" (or "edges = PSEUDOGEODESIC" until there is a real geodesic implementation) because "edges" refers to a 1-dimensional line and not a 2-dimensional surface. By making these changes, I think it adds clarity and specificity that we are indeed referring to the edges and not implying the type of surface. I think by using the terms "planar" and "spherical" we are implying that the type of surface is either a plane or a sphere. In cases where the spatial model is more complex, like an ellipsoid or geoid, it needs to be very clear to what we are actually referring with the term "edge" and what assumptions are being made about not only the edge but also its related surface. If there is ambiguity about the term, it can cause erroneous assumptions, which can compound spatial computational errors where utmost precision and accuracy are paramount, such as in the defense and intelligence sectors. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
