ashvina commented on code in PR #10926:
URL: https://github.com/apache/iceberg/pull/10926#discussion_r1801815505
##########
core/src/main/java/org/apache/iceberg/hadoop/HadoopFileIO.java:
##########
@@ -120,6 +120,12 @@ public void setConf(Configuration conf) {
@Override
public Configuration getConf() {
+ // Create a default hadoopConf as it is required for the object to be
valid.
+ // E.g. newInputFile would throw NPE with getConf() otherwise.
+ if (hadoopConf == null) {
+ this.hadoopConf = new SerializableConfiguration(new
Configuration())::get;
Review Comment:
Is there a potential for a race condition here? Do you see a need to add
synchronization to protect this instantiation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
