nastra commented on code in PR #10926:
URL: https://github.com/apache/iceberg/pull/10926#discussion_r1799473360
##########
core/src/main/java/org/apache/iceberg/hadoop/HadoopFileIO.java:
##########
@@ -74,7 +74,7 @@ public HadoopFileIO(SerializableSupplier<Configuration>
hadoopConf) {
}
public Configuration conf() {
- return hadoopConf.get();
+ return getConf();
Review Comment:
I don't think it's enough to just update this call. You'd basically need to
update every place in this class that uses `hadoopConf.get()` to `conf()` or to
`getConf()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
