rahil-c commented on code in PR #11180:
URL: https://github.com/apache/iceberg/pull/11180#discussion_r1797270059
##########
.palantir/revapi.yml:
##########
@@ -1058,6 +1058,11 @@ acceptedBreaks:
new: "method void
org.apache.iceberg.encryption.PlaintextEncryptionManager::<init>()"
justification: "Deprecations for 1.6.0 release"
"1.6.0":
+ org.apache.iceberg:iceberg-api:
+ - code: "java.class.defaultSerializationChanged"
+ old: "class org.apache.iceberg.expressions.ResidualEvaluator"
+ new: "class org.apache.iceberg.expressions.ResidualEvaluator"
+ justification: "local testing"
Review Comment:
@rdblue Will use the example of the existing `FileScanTaskParser`. Currently
when deseriaizing FIleScanTasks in the `fromJson` of this parser (which is
similar to the `RESTFileScanTaskParser`, in order to construct a
`BaseFileScanTask` it takes in a `ResidualEvaluator`
https://github.com/apache/iceberg/blob/main/core/src/main/java/org/apache/iceberg/FileScanTaskParser.java#L117
The Residual current constructor currently requires a `spec` as well as a
`caseSensitive` flag
https://github.com/apache/iceberg/blob/main/api/src/main/java/org/apache/iceberg/expressions/ResidualEvaluator.java#L84.
At the time of deserialization we do not have either, hence an additional
constructor was created which only passes in the `filter`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
