amogh-jahagirdar commented on code in PR #11180: URL: https://github.com/apache/iceberg/pull/11180#discussion_r1797258000
########## api/src/main/java/org/apache/iceberg/expressions/ResidualEvaluator.java: ########## @@ -89,6 +89,12 @@ public static ResidualEvaluator of(PartitionSpec spec, Expression expr, boolean } } + public static ResidualEvaluator of(Expression expr) { + // TODO this constructor is used for REST scan planning Review Comment: Yeah, discussed with @rahil-c this is something that can be late "bound" like Spec/schema once we have the information. Then we wouldn't need these changes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org