manuzhang commented on code in PR #650: URL: https://github.com/apache/iceberg-rust/pull/650#discussion_r1777943490
########## crates/integrations/datafusion/src/table.rs: ########## @@ -56,6 +56,13 @@ impl IcebergTableProvider { Ok(IcebergTableProvider { table, schema }) } + + /// Asynchronously tries to construct a new [`IcebergTableProvider`] + /// using the given table. Can be used to create a table provider from an existing table regardless of the catalog implementation. + pub async fn try_new_from_table(table: Table) -> Result<Self> { Review Comment: @a-agmon Specifically for usage of this API a UT is needed, I think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org