liurenjie1024 commented on PR #650: URL: https://github.com/apache/iceberg-rust/pull/650#issuecomment-2378289659
> Not familiar with rust, but do we have tests for such changes? Good point, this is mostly an access modifier change, and other parts are already covered by test, so generally LGTM. But it would be better to have some tests to cover the usage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
