stevenzwu commented on PR #11073:
URL: https://github.com/apache/iceberg/pull/11073#issuecomment-2375462905
I think we should first add Javadoc to `ThreadPools.newWorkerPool` that it
adds shutdown hook. It is not obvious from the method name.
regarding `ThreadPools.newNonExitingWorkerPool`, the name
`newNonExitingWorkerPool` is a little awkward to me. Ideally, the current
`newWorkerPool` should be called `newExitingWorkerPool` and this new method can
be called `newWorkerPool`. But we can't change it for compatibility. Hence, I
am not against adding `newNonExitingWorkerPool`.
another option is to make `ThreadPools.newDaemonThreadFactory` public. The
real one-line space saving in `newNonExitingWorkerPool` really comes from the
thread factory construction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
