amogh-jahagirdar commented on code in PR #11131:
URL: https://github.com/apache/iceberg/pull/11131#discussion_r1776097229
##########
core/src/main/java/org/apache/iceberg/ManifestFilterManager.java:
##########
@@ -78,9 +78,11 @@ public String partition() {
private boolean failMissingDeletePaths = false;
private int duplicateDeleteCount = 0;
private boolean caseSensitive = true;
+ private boolean allDeletesReferenceManifests = true;
Review Comment:
The downside of defaulting true and setting false is that every place which
exposes a deletion where it's impossible to reference a manifest needs to be
updated. But that seemed like only a handful of places, and probably won't grow?
Worth considering other approaches where this defaults false, and at the end
we figure out if it's true. I think this would require keeping track of a
map<string, set<String>> manifestToFiles and comparing the set with the
deletePaths...but that implies duplicating all the paths in memory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
