amogh-jahagirdar commented on code in PR #11131:
URL: https://github.com/apache/iceberg/pull/11131#discussion_r1775395015
##########
core/src/main/java/org/apache/iceberg/ManifestFilterManager.java:
##########
@@ -120,13 +122,15 @@ protected void deleteByRowFilter(Expression expr) {
Preconditions.checkNotNull(expr, "Cannot delete files using filter: null");
invalidateFilteredCache();
this.deleteExpression = Expressions.or(deleteExpression, expr);
+ this.allDeletesHaveReferencedManifests = false;
Review Comment:
With this approach, there's still technically the chance of false positive
in the case that there's a row filter but there may be a referenced manifest
that actually could be used as a source of truth for determining if a manifest
should be rewritten or not.
I'm less concerned about this false positive case since for sync
maintenance we wouldn't be passing in row filters to begin with but let me see.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
