sfc-gh-aixu commented on code in PR #11179:
URL: https://github.com/apache/iceberg/pull/11179#discussion_r1775641598
##########
parquet/src/main/java/org/apache/iceberg/parquet/PruneColumns.java:
##########
@@ -40,7 +43,7 @@ class PruneColumns extends ParquetTypeVisitor<Type> {
}
@Override
- public Type message(MessageType message, List<Type> fields) {
+ public Type message(StructType iStruct, MessageType message, List<Type>
fields) {
Review Comment:
You are right. We do use `expected` elsewhere. Updated.
##########
parquet/src/main/java/org/apache/iceberg/parquet/PruneColumns.java:
##########
@@ -40,7 +43,7 @@ class PruneColumns extends ParquetTypeVisitor<Type> {
}
@Override
- public Type message(MessageType message, List<Type> fields) {
+ public Type message(StructType iStruct, MessageType message, List<Type>
fields) {
Review Comment:
You are right. We do use `expected` elsewhere. Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
