RussellSpitzer commented on code in PR #11179:
URL: https://github.com/apache/iceberg/pull/11179#discussion_r1775558576
##########
parquet/src/main/java/org/apache/iceberg/parquet/PruneColumns.java:
##########
@@ -40,7 +43,7 @@ class PruneColumns extends ParquetTypeVisitor<Type> {
}
@Override
- public Type message(MessageType message, List<Type> fields) {
+ public Type message(StructType iStruct, MessageType message, List<Type>
fields) {
Review Comment:
We generally avoid names like this, I would suggest something like
tableStruct
##########
parquet/src/main/java/org/apache/iceberg/parquet/PruneColumns.java:
##########
@@ -40,7 +43,7 @@ class PruneColumns extends ParquetTypeVisitor<Type> {
}
@Override
- public Type message(MessageType message, List<Type> fields) {
+ public Type message(StructType iStruct, MessageType message, List<Type>
fields) {
Review Comment:
We generally avoid names like `iStruct`, I would suggest something like
tableStruct
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
