szehon-ho commented on code in PR #9335:
URL: https://github.com/apache/iceberg/pull/9335#discussion_r1762097553
##########
.palantir/revapi.yml:
##########
@@ -1136,6 +1136,78 @@ acceptedBreaks:
new: "method org.apache.iceberg.BaseMetastoreOperations.CommitStatus
org.apache.iceberg.BaseMetastoreTableOperations::checkCommitStatus(java.lang.String,\
\ org.apache.iceberg.TableMetadata)"
justification: "Removing deprecated code"
+ - code: "java.method.returnTypeTypeParametersChanged"
Review Comment:
Unfortunately I think we have to keep the old API's for one release. Let's
just make a new method then. Hopefully we can re-use logic between these.
##########
core/src/main/java/org/apache/iceberg/MetricsUtil.java:
##########
@@ -174,6 +175,8 @@ public static MetricsModes.MetricsMode metricsMode(
field.type(),
file.upperBounds().get(field.fieldId()))));
public static final String READABLE_METRICS = "readable_metrics";
+ public static final String REF_SNAPSHOT_ID = "reference_snapshot_id";
Review Comment:
I still feel we should move this one.
##########
.palantir/revapi.yml:
##########
@@ -1136,6 +1136,78 @@ acceptedBreaks:
new: "method org.apache.iceberg.BaseMetastoreOperations.CommitStatus
org.apache.iceberg.BaseMetastoreTableOperations::checkCommitStatus(java.lang.String,\
\ org.apache.iceberg.TableMetadata)"
justification: "Removing deprecated code"
+ - code: "java.method.returnTypeTypeParametersChanged"
Review Comment:
Unfortunately I think we would need to keep the existing method for at least
a release and deprecate it. Hopefully we can have the logic re-used between
old and new methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
