hsiang-c commented on code in PR #9335:
URL: https://github.com/apache/iceberg/pull/9335#discussion_r1742041236
##########
flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkMetaDataTable.java:
##########
@@ -498,11 +506,11 @@ public void testAllFilesUnpartitioned() throws Exception {
// Check all files table
List<Row> actualFiles =
- sql("SELECT %s FROM %s$all_files ORDER BY content, record_count asc",
names, TABLE_NAME);
+ sql("SELECT %s FROM %s$all_files ORDER BY file_path", names,
TABLE_NAME);
List<GenericData.Record> expectedFiles =
ListUtils.union(expectedDataFiles, expectedDeleteFiles);
- expectedFiles.sort(Comparator.comparing(r -> ((Integer)
r.get("content"))));
- assertThat(actualFiles).hasSize(3);
+ expectedFiles.sort(Comparator.comparing(r ->
r.get("file_path").toString()));
Review Comment:
Order by `file_path` for both actual files and expected files is
deterministic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
