danielcweeks commented on code in PR #10929:
URL: https://github.com/apache/iceberg/pull/10929#discussion_r1757475131


##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -393,6 +438,15 @@ private LoadTableResponse loadInternal(
 
   @Override
   public Table loadTable(SessionContext context, TableIdentifier identifier) {
+    if (!endpoints.contains(ResourcePaths.V1_LOAD_TABLE)) {
+      throw new NoSuchViewException(
+          "Unable to load view %s.%s: Server does not support endpoint %s %s",

Review Comment:
   @rdblue this feels like a narrow case (I'm not sure you can support views 
without being able to load tables.  Technically there are things you could do, 
but they're largely not meaningful).  However, I think we need to be explicit 
that the failure was due to `load_table` not being supported.  Otherwise, it's 
unclear as to why it wasn't able to load because:  The message says unable to 
load, the exception says it doesn't exist, but the truth is that it's not a 
supported operation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to