nastra commented on code in PR #10929:
URL: https://github.com/apache/iceberg/pull/10929#discussion_r1757307497
##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -394,6 +445,10 @@ private LoadTableResponse loadInternal(
@Override
public Table loadTable(SessionContext context, TableIdentifier identifier) {
+ if (!endpoints.contains(Endpoint.V1_LOAD_TABLE)) {
+ throw new NoSuchTableException("Unable to load table %s.%s", name(),
identifier);
Review Comment:
> I don't feel like this message is right. Shouldn't we say "Loading tables
is not supported by the Catalog"? I'm not sure if this really matters too much
since pretty much everything requires table loading.
I had this in my initial implementation but changed it after
https://github.com/apache/iceberg/pull/10929#discussion_r1715632323.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
