nastra commented on code in PR #11048: URL: https://github.com/apache/iceberg/pull/11048#discussion_r1754106397
########## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestTagDDL.java: ########## @@ -45,19 +43,9 @@ public class TestTagDDL extends ExtensionsTestBase { private static final String[] TIME_UNITS = {"DAYS", "HOURS", "MINUTES"}; - @Parameters(name = "catalogName = {0}, implementation = {1}, config = {2}") Review Comment: @manuzhang what exactly is this PR "fixing"? Do we actually need to test this across all catalogs? I believe the goal here was to just test this functionality with any catalog -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org