nastra commented on code in PR #11048:
URL: https://github.com/apache/iceberg/pull/11048#discussion_r1754101092
##########
spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/CreateOrReplaceTagExec.scala:
##########
@@ -48,7 +48,8 @@ case class CreateOrReplaceTagExec(
.orNull
Preconditions.checkArgument(snapshotId != null,
- "Cannot complete create or replace tag operation on %s, main has no
snapshot", ident)
+ "Cannot complete create or replace tag operation on %s, main has no
snapshot",
Review Comment:
if we do this here, then we should align this for creating/replacing
branches as well. Additionally, we should check how we do this in other Exec
classes to align things properly. That being said, I think it's better to
handle this in a separate PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
