amogh-jahagirdar commented on issue #11085: URL: https://github.com/apache/iceberg/issues/11085#issuecomment-2332705117
Hey @mderoy check out https://github.com/apache/iceberg/pull/10820 which tried to address this but we determined that adding to this Conversions logic is probably not the right way to go since Iceberg considers partition value to String a 1 way conversion. The other way existed for Hive table migration but again probably not good to keep adding cases to that since the string representation is not standardized. Before all that, I'm curious what you're trying to do, is this a Hive table migration to Iceberg? It doesn't sound like it based on ``` when trying to insert into a table partitioned on identity for a time datatype, we get the following error trying to commit Unsupported type for fromPartitionString: time ``` If you're inserting into an Iceberg table, this Conversions logic shouldn't even come into the picture so I'm a bit confused there... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
