liurenjie1024 commented on PR #577: URL: https://github.com/apache/iceberg-rust/pull/577#issuecomment-2328362065
> > Thanks @FANNG1 for this pr. However I think there are some prepartion work before we can actually finished this pr. If we can narrow down the goal of this pr to change type for `UnboundPartitonSpec` to `PartitionSpec` only, we can merge this. > > @liurenjie1024 , thanks for your review, let's keep consistent with what means `change type for UnboundPartitonSpec to PartitionSpec only`. The PR consistent serval parts: > > 1. Change `UnboundPartitonSpec` to `PartitionSpec` in TableCreation > 2. Use `PartitionSpec` to build the table metadata > 3. Integration tests about creating and showing partition table > 4. Examples about create partition table and read data from table. > > What you mean is just keeping the first part? Yes, I think keeping only part 1 is a good start. Add `PartitionSpec` is sth how similar to a transaction with two actions: 1. Add partition spec 2. Set default partition spec. I think it's better to implement them in transaction api. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
