FANNG1 commented on code in PR #577:
URL: https://github.com/apache/iceberg-rust/pull/577#discussion_r1740693686


##########
crates/iceberg/src/spec/table_metadata.rs:
##########
@@ -301,12 +302,7 @@ impl TableMetadataBuilder {
         } = table_creation;
 
         let partition_specs = match partition_spec {
-            Some(_) => {
-                return Err(Error::new(
-                    ErrorKind::FeatureUnsupported,
-                    "Can't create table with partition spec now",
-                ))
-            }
+            Some(p) => HashMap::from([(p.spec_id(), Arc::new(p))]),

Review Comment:
   sorry, I couldn't understand `AddPartitionSpec transaction api`, could you 
provide more context?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to