fengjiajie commented on code in PR #11073:
URL: https://github.com/apache/iceberg/pull/11073#discussion_r1741622214


##########
flink/v1.18/flink/src/main/java/org/apache/iceberg/flink/source/FlinkInputFormat.java:
##########
@@ -93,7 +93,7 @@ public FlinkInputSplit[] createInputSplits(int minNumSplits) 
throws IOException
     // Called in Job manager, so it is OK to load table from catalog.
     tableLoader.open();
     final ExecutorService workerPool =
-        ThreadPools.newWorkerPool("iceberg-plan-worker-pool", 
context.planParallelism());
+        ThreadPools.newWorkerPool("iceberg-plan-worker-pool", 
context.planParallelism(), false);

Review Comment:
   shutdown in the finally block



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to